search

UBC-ECE-Sasha / PIM-Embedding-Lookup

6 stars 5 forks source link

Confusing statement #3

Open jnider opened 4 years ago

jnider commented 4 years ago

https://github.com/UBC-ECE-Sasha/PIM-Embedding-Lookup/blob/1830cfbfb4fb21d810d3a6411575b717440c2a62/upmem/src/emb_host.c#L99

Is this trying to skip some rows? It is hard for me to read this, and convince myself that the algorithm is correct because I don't really understand what the code is trying to do. Can you add a comment here?

nzarif commented 4 years ago

This is just copying data from the 1D array that we have received from Python to the buffers that we are preparing to be pushed to each dpu.