search

UBC-ECE-Sasha / PIM-Embedding-Lookup

6 stars 5 forks source link

Inconsistent formatting #9

Closed johnramsden closed 3 years ago

johnramsden commented 3 years ago

This one's more of a preference thing but the current formatting is a bit inconsistent.

Can we reformat everything according to a style?

For example, I used this .clang-format for PIM_HDC, if you're happy with the styling I can reformat all the code according to it. Otherwise we can set up a new style configuration.

I'm not too concerned with what we choose for style as long as it's consistent.

nzarif commented 3 years ago

I have not used such a thing before. Can you elaborate more on that?

johnramsden commented 3 years ago

It basically auto formats your code according to configuration file settings.

nzarif commented 3 years ago

Nice! It does it at compile time? when we build?

johnramsden commented 3 years ago

It needs to be run manually, we could add something to the makefile, ie make format that does it. Do you have any preferences for formatting?

nzarif commented 3 years ago

Nice! No, I don't have any preference. Feel free to use any formatting you like. Thanks

johnramsden commented 3 years ago

Instructions in #11