search

UBC-MDS / Coffee_quality_rating_predictor

Coffee Rating Prediction for DSCI 522
MIT License
1 stars 8 forks source link

Milestone 1 draft complete #13

Closed khbunyan closed 2 years ago

khbunyan commented 2 years ago

Hello Team

All the sections for Milestone 1 are now complete and uploaded to the repo. Please have a look and feel free to suggest any changes/updates. Myself and Arlin have done a review of Grammar/ Spelling and also checked that our script downloads data correctly.

@berkaybulut or @michelle-wms - would you mind doing the submission this week? This only needs to be done by one team member.

Thanks! Kristin

arlincherian commented 2 years ago

Follow-up: Florencia has posted a link on slack with the submission guidelines. For reference: https://ubc-mds.slack.com/archives/C24HUNRJL/p1637365467150600

Thanks, team!

michelle-wms commented 2 years ago

Yes I can do the submission this week! Sounds good, will review the work. Thanks v much guys!

michelle-wms commented 2 years ago

Hi guys, couple of comments before I submit:

  1. The requirements said "You are not required upload the data to your project repository." So I am removing all the raw csv files from our repo. I think generally speaking, github repos don't usually store the datasets as common practice as well (since they can get very big).
  2. I am making minor edit to the name of the EDA literate document so that it's clearer to the TA which notebook contains our actual EDA (So I will change from coffee_rating.ipynb to coffee_rating_milestone1_EDA_final.ipynb)
  3. For README, introduction: "Our team chose to analyze the coffee quality data set to identify the strongest predictor of coffee quality. " --> I am changing to "Our team will use machine learning techniques to predict coffee quality scores on arabica coffees." Because "predictor" in machine learning speak means "feature" which is slightly misleading, so it sounded like we're trying to figure out which feature is the best feature.

Let me know if you've any thoughts - else if ok, please give thumbs up! Thank you.

khbunyan commented 2 years ago

Hey @michelle-wms once the milestone is submitted, can you please close out this issue? Thanks! Happy Saturday.

michelle-wms commented 2 years ago

Sure will do, I'm coordinating with Berkay to finish up some small stuff! Should be done by tonight (currently outside now). Thanks! Happy weekend too

On Sat, 20 Nov 2021, 12:10 khbunyan, @.***> wrote:

Hey @michelle-wms https://github.com/michelle-wms once the milestone is submitted, can you please close out this issue? Thanks! Happy Saturday.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/UBC-MDS/DSCI_522_GROUP3_COFFEERATINGS/issues/13#issuecomment-974705172, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIHFYVDATW4B47T4VTGLVVLUM76EHANCNFSM5INOJXQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

michelle-wms commented 2 years ago

Submitted