Milestone 1 Review

[Ivyqiuhan]

Nice job! I provide here some comments and your grades for the first milestone. Please address these concerns in your third milestone submission.

1. Draft a Team work contract: Correctness

2. Project set-up: Mechanics

• when running coffee_quality_eda_script.ipynb, I am having this error: ModuleNotFoundError: No module named 'altair_saver' at cell 14

3. Project proposal: reasoning

• The link in the Exploratory EDA section does not work
• What about data visualization? What specifically are you going to do? Will you do a heat map with correlation to make sure that variables are not redundant?
• What about class balance, there could be an imbalance in the classes, in which you would have to under sample or oversample.
• What about missing data, how will you handle the missing data?
• For these algorithms, what packages will you use?

4. A script that downloads the data: Accuracy

5. A script that downloads the data: Quality

6. Exploratory data analysis in a literate code document: QUALITY

7. Exploratory data analysis in a literate code document: VIZ

8. Exploratory data analysis in a literate code document: REASONING

• maybe put the explanation after each plot, to make people easier to follow

9. Exploratory data analysis in a literate code document: ACCURACY
10. Expectations: Mechanics

[michelle-wms]

@Ivyqiuhan Hi Ivy, sorry I think you were confused by the file names, but actually our EDA notebook for Milestone 1 is the one called "coffee_rating_milestone1_EDA_final.ipynb" under src folder. Could you instead look at that notebook for our EDA portion for milestone 1? In that way, there's no need for you to run script, it's just a literate notebook that you can see directly for our visualization and analysis. We sincerely apologise for the confusion of names in the src folder. Appreciate your help to regrade/take a second look!

[khbunyan]

Hi @Ivyqiuhan

Thank you for your feedback. We have made the following changes to our project based on your comments:

• Regarding comment 2 and the EDA comments in this issue:
  • We re-organized our prelim- EDA so that it would be easier to identify it as preliminary and removed altair from the dependencies as it was no longer needed as a result of this change:b19dcbb

The EDA section has been submitted for a re-grade, as you are aware.

Thank you!