Dockerfile & README redundancy

UBC-MDS / Credit_Card_Default_Prediction_Group13

Group 13 of DSCI 522 in the year 2022-23

https://ubc-mds.github.io/Credit_Card_Default_Prediction_Group13/doc/report.html

Other

2 stars 3 forks source link

Dockerfile & README redundancy #72

Closed renee-kwon closed 1 year ago

renee-kwon commented 1 year ago

Hi team,

Are we able to combine the RUN apt get lines (12-16) and the R packages in our dockerfile?
Also, I think we could simplify the usage part in our README to either "using without docker" and "using docker", as in the instructions for milestone 4. That is what the examples have done too.

Please let me know your thoughts and what I can work on before submission today.

hcwang24 commented 1 year ago

Hi Renee,

Regarding the second point, we should be more comprehensive and give all the options. I have checked with many previous groups' examples and that's what they have used.

HanChen

ChesterAiGo commented 1 year ago

Work on point 1 now.

renee-kwon commented 1 year ago

Ok - i think it may be what is expected of us, though (point 2). I am looking at the history of ttimbers' repo and she has updated throughout the process and reduced it to the two options. I will ask for clarification on slack.