search

UBC-MDS / CrossPy

A package for cross-validation in Python
MIT License
1 stars 4 forks source link

more feedback for milestone 2 #22

Open meghanallen opened 6 years ago

meghanallen commented 6 years ago

Each of your test cases should be in its own test function that is named in a descriptive way. Then you can easily tell which test case has failed when you get failures. You've mostly done a really good job of this but there are a few test cases that need to be split into their own function (as one example - test_shuffle_as_boolean)

There was a requirement to show that your tests provide 100% branch coverage but I don't see any documentation for this. See https://github.ubc.ca/ubc-mds-2017/DSCI_524_collab-sw-dev_students/issues/9 for more info.

Please fix both of these issues before the next milestone.

ShunChi100 commented 6 years ago

@meghanallen Thank you very much for the feedback. We have modified our codes according to the two comments

  1. We have modified test functions so that one function one test case.
  2. We have a full branch coverage now and tested by pytest-cov. The output can be viewed here: https://htmlpreview.github.io/?https://github.com/UBC-MDS/CrossPy/blob/master/CrossPy/htmlcov/index.html

Please let me know if there is any question.