Proposal feedback - Githubissues

UBC-MDS / DSCI-522-Jes-Alex

An analysis of Lebron James's Shots from the 2014-2015 NBA season.

0 stars 3 forks source link

Proposal feedback #21

Closed eric-f closed 5 years ago

eric-f commented 5 years ago

Mechanics

Need to put the proposal in README
The link in your proposal repo only redirect to the release page of the project repo. You can also create a direct link to v1.0 of the repo with https://github.com/UBC-MDS/DSCI-522-Jes-Alex/tree/v.1.0.
Might want to include the data importing and tidying script in README or proposal. Right now there is no link to this script and I have to find it myself in src/

Reasoning

Probably not covered by the machine learning course at the time of writing but might want to explain how you are going to tune and evaluate the performance of the decision tree.
For visualization, not sure how you can plot 'a tree that displays mainly our most predictive features' instead of the whole tree. Might want to elaborate.

Other comments

I wonder if the data has the location where the shot is taken. Would be interesting to plot a 'heatmap' of that? I guess location on the court would be a strong predictor?

jessimk commented 5 years ago

Thanks Eric!

@ehhope and I included your recommendations for Milestone 1.

We clarified the reasoning, especially around feature importance-- but let us know what you think.

We would have loved to create a heatmap! The data didn't have location though so we just looked at distance. Might give this some more thought though in case there's a way to use a scatter plot.

Looking forward to hearing your feedback on the next round :)