Open ttimbers opened 5 years ago
Hi @ttimbers ,
I went into this last week. Originally, I listed all the above-mentioned dependencies in the final makefile line. But I got an error message as such:
I consulted Ozum on this and she recommended me to remove these by-products as dependencies in the final report. And only after that, make all
runs again, and generates successfully the final report.
For the important "by products":
Even though they are included in the final report, they are supplementary creations /by-products from our scripts used to create the main products - age-stat.csv and the classifier.
results/imgs/job_age.png
, is created as a by-product from the data_vis script used to create age_stat.csv
. results/imgs/Cross-Validation-Scores.png
and results/imgs/Decision-Tree-depth2.png
are the by-product from the create tree script to create the decision tree classifier.
@ttimbers please let me know if this issue can be closed?
Thanks!
results/imgs/job_age.png
,results/imgs/Cross-Validation-Scores.png
, andresults/imgs/Decision-Tree-depth2.png
are all dependencies ofdocuments/Bank-Marketing-Findings.md
and thus should be listed as such here: https://github.com/UBC-MDS/DSCI-522_Bank-Marketing/blob/08c62e7ea4c4fce352207e2aca2178aa1edfae91/makefile#L33They should also be listed as targets in the rules that build them.