Milestone 3: Code Quality - Githubissues

UBC-MDS / DSCI522_group315

MIT License

0 stars 3 forks source link

Milestone 3: Code Quality #44

Open ksedivyhaley opened 4 years ago

ksedivyhaley commented 4 years ago

To improve:

Makefile summary should have a slightly more detailed description of what the file does - a sentence instead of just "ufc juding analysis data pipe"
Could have a second test at the end of download to ensure it's actually been downloaded
Would be nice to functionalize more (#34) but the commenting does make it easy to read in the current state

Done well:

Good added tests to download, preprocess, EDA!
Analysis: simplification of output paths is well implemented
Included echo lines based on peer feedback