Milestone #3: Outstanding tasks

[larahabashy]

1. create a sub-directory for prediction results in results directory

   • update makefile --> results/predictions

2. move figures inside results/figures

   • this is already encoded in the scripts.
   • update repo with latest make all output.

3. add comments to the makefile as per milestone 3 expectations: (done)

   The Makefile must be well documented. This means comments throughout, readable code and a brief summary at the top of each file that answers who wrote it, when it was written and what it does

4. update the usage section in Readme file (done)

[d-sel]

@larahabashy, for 1. are you referring to the output of fit_predict_default_model.py to go to a sub-directory of 'results'?

[larahabashy]

@d-sel yes. I created a subdirectory in results for the figures.

[d-sel]

@d-sel yes. I created a subdirectory in results for the figures.

Just for clarity: are there items on this list still to be done or have they all been completed?

[larahabashy]

@d-sel The items below are still to be done.

1. create a sub-directory for prediction results in results directory

• update makefile --> results/predictions

2. move figures inside results/figures

• this is already encoded in the scripts.
• update repo with latest make all output.

3. add comments to the makefile as per milestone 3 expectations:

The Makefile must be well documented. This means comments throughout, readable code and a brief summary at the top of each file that answers who wrote it, when it was written and what it does

[d-sel]

I am trying to assist with the above, but am running into issues with running the clean data script from the make file. Did it successfully run for you?

[larahabashy]

@d-sel yes it did. what's the error you're getting?

[d-sel]

Its saying the downloaded file is not a feather file.

[larahabashy]

Is this error possibly related to the download script?