search

UBC-MDS / DSCI522_group_12

MIT License
0 stars 5 forks source link

Milestone 2 Feedback #46

Closed ahofmann4 closed 3 years ago

ahofmann4 commented 3 years ago

First command for python should not be surrounded by '<' '>' on either end.

There was a significant error that took some time to trace, see below:

Running Rscript src/eda_cred.r --train=data/processed/training.feather --out_dir=results gave this error: Error: Creates eda plots for the pre-processed training data from the default of credit card clients data (from http://archive.ics.uci.edu/ml/datasets/default+of+credit+card+clients). Saves the plots as a png file. Usage: Rscript src/eda_cred.r --train= --out_dir= Options: --train= Path (including filename) to training data (which needs to be saved as a feather file) --out_dir= Path to directory where the plots should be saved Execution halted I have traced this to not having defined corr_plot before calling it on line 64 in eda_cred.r

larahabashy commented 3 years ago

Hi @ahofmann4, apologies for taking so much time to trace the error. This script has been debugged as of milestone 3. Thank you.

ahofmann4 commented 3 years ago

Glad to hear the error has been fixed! :)

On Tue, Dec 8, 2020, 9:41 AM larahabashy notifications@github.com wrote:

Hi @ahofmann4 https://github.com/ahofmann4, apologies for taking so much time to trace the error. This script has been debugged as of milestone 3. Thank you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/UBC-MDS/DSCI522_group_12/issues/46#issuecomment-740790314, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQYPGCPNQXUV6ROQ3BQHZLSTZQLJANCNFSM4UQBOFWQ .