UBC-MDS / DSCI532-peer-review

0 stars 5 forks source link

Data Science Salaries - Group 19 #1

Open joshsia opened 2 years ago

joshsia commented 2 years ago

To complete by the group


  1. Review the group that is one number ahead of your group's number. For example, if you are group 5, review group 6. If you are group 30, review group 1. Paste your answers in the issue of the group assigned.

To complete by the group reviewing:

Persona

Frontend / layout

Backend

Documentation

Indicate something you would like to include in your own app after reviewing this one


gn385x commented 2 years ago

Reviewer: Group 18

Great work, team! I love how relevant and "timely" the app is, to many of us; and you have done a great job on delivering it. Below are some suggestions to make the app even better!

Persona

  1. In the usage scenario, Heroku needs to know how remote Data Science jobs compare with in-person jobs. Thus, I would suggest adding a chart to illustrate how the remote nature of the job impacts the salary by using the RemoteWork variable.
  2. To answer the stated research question "Data Science professionals in which countries are paid the highest?", I think it would be helpful to add a ranking plot of countries sorted by the salary statistics (i.e. median) so that users can quickly see the top five countries that pay data scientists the highest. The current world map is helpful, but is not as efficient when comparing countries.
  3. According to the usage scenario, Heroku wants to compare salaries in quite a few ways: (1) by country: Canada vs. US, (2) by education level: PhD vs. master's level, and (3) by work location: remote vs. in-person. If Heroku is a typical user for whom the dashboard is designed to help, I would suggest adding some sort of functionality where users can do comparison easily.
  1. It is likely that the user would be most interested in the salary distribution based on his/her own age, gender, education level, and coding experience. Thus, I suggest adding the capability to filter out those characteristics simultaneously. For example, if the user is a woman, she may primarily be interested in woman's salary distribution; therefore, she may not need to see the boxplot by gender.
  2. Coding experience is a key factor affecting placement and salary of newly graduated data science students. Therefore, I appreciate how the dashboard highlights its roles by giving it a substantial portion of the dashboard. However, I do not find the current version of this section very intuitive and effective, so there is more room for improvement. For example, I am not clear about the filter question "Are you a Data Scientist?"; or the interactive plot for each country seems to be more detailed than needed.
  3. Another possible improvement could be to give the option of using the converted currency in USD or the original currency as in the original data set. A Chinese user, for instance, who is only interested in the labor market in China, may prefer not to do all the conversion between USD and CNY.

Frontend / layout

Backend

Documentation

Indicate something you would like to include in your own app after reviewing this one

I like the fact that the team make use of the data available and build the analysis from many aspects. If given more time, our group would definitely try to do the same.