UBC-MDS / DSCI532-peer-review

0 stars 5 forks source link

Group 28 - Global Cost of Living #28

Open Arushi282 opened 2 years ago

Arushi282 commented 2 years ago

DSCI532-peer-review


To complete by the group


To complete by the group reviewing:

Persona

Frontend / layout

Backend

Documentation

Indicate something you would like to include in your own app after reviewing this one


kphaterp commented 2 years ago

Group 27 Review of Group 28: Global Cost of Living

Overall, your dashboard looks excellent. Many of the discussion points that we bring up are small details and personal preferences of ours. Personally, we think your dashboard is already very complete barring a few technical bugs that are easily fixable.

Persona

Provide 3 pieces of constructive feedback that could help the app to be better suited to the scenario it was designed for

Provide 3 pieces of constructive feedback that could help the app to be better suited to the user (persona) it was designed for

Frontend

Are the text (plot labels / titles / subtitles) easy to read? Yes, they are formatted very well and are very easy to read. One note is that the map requires us to scroll right and left to view the entire map. Is there a way to fix this? This could just be related to our computers as well....

Are the plots selected appropriate for the data? Can you think of other alternatives or improvements for the plots regarding interactivity/reactivity or plot selection? The plots are more than appropriate and are very informative for users. Potentially alternatives is to find a way to make the click interactivity on the map plot interact with other plots in the dashboard.

Was the dashboard organized in a way that was easy to read (columns / rows) or you would suggest a change in this sense? Yes, the dashboard was organized very well and looked fantastic!

Would you prefer including tabs / navbars to improve the navigation or you think it is better to visualize everything in one screen by the nature of the content? We believe that the way that this group has set up the dashboard, is completely fine, if not perfect, for their project.

Are the plots or other images described properly for the persona described? The plots are described properly for the persona described. One note is that the y-axis of the 'average property price per square meter' doesn't indicate the right units we believe. Moreover, the y-axis units should be (Property price/m^2)

Backend

Are the options that you can select in the widgets working fine or have you found some cases where it is not working? The multi-selection of the geographic location drop down menu doesn't seem to function as intended. Moreover, when you select multiple geographic locations, the map only filters for one of these specified locations. Something to look into in the future.

If there are interactive plots: are the labels clear and easy to understand? The labels are very clear and easy to understand.

Documentation

Was the documentation easy to understand from the README.md how to use the app? How could the documentation be improved? Documentation read well and created a detailed picture about how to use the app. If you could include a table of contents at the beginning of the README that would be fantastic!

Was the app intuitive to use without reading the documentation? What information could be good to include? Their app was absolutely intuitive without needing to read the documentation. Perhaps some information on the dashboard about how to use the app could be included, although we don't believe this is necessary.

Indicate something you would like to include in your own app after reviewing this one: We really loved your use of the sidebar on the left hand side of your dashboard. This is not something that we included in our own project, but we think it looks aesthetically beautiful. The colours you have selected also look very professional and is easy to look at.

Group 27

Affrin101 commented 2 years ago

Thank you Group 27 for the wonderful feedback. We really found those feedbacks very helpful and constructive and tried to implement as many as we could.
Following are the changes that we implemented which can also be seen here

Feedbacks incorporated: Persona

Frontend

Backend

Changes not incorporated:

Once again, thank you for your valuable feedback as it helps us improve, keep them flowing in.!!