UBC-MDS / DSCI532-peer-review

0 stars 5 forks source link

Group 26 Game sales #29

Open RamiroMejia opened 2 years ago

RamiroMejia commented 2 years ago

DSCI532-peer-review

  1. Open an issue with the name of your group and app Use this template:

To complete by the group


  1. Review the group that is one number ahead of your group's number. For example, if you are group 5, review group 6. If you are group 30, review group 1. Paste your answers in the issue of the group assigned.

To complete by the group reviewing:

Persona

Frontend / layout

Backend

Documentation

Indicate something you would like to include in your own app after reviewing this one


gfairbro commented 2 years ago

Hey Guys! Love the app. I think it is a good focused purpose and delivers on the intended goal. Here are a few suggestions!

Scenario:

Persona: Again some of these are pie in the sky!

Frontend:

Backend: I didnt find any broken functionality or unresponsive selections.

Documentation: I was able to run the app locally by following the instructions, and the heroku link is self explanatory. I think i covered my useability issues above, which were not major but could help improve the overall 'slickness.'

Good work guys! I know this technology is a challenge and the app looks great.

katerinkus commented 2 years ago

I am adding a few comments to @gfairbro review. Your group made a great app, I can see how you could keep building on it, too, if we had more time in this course.

To complete by the group reviewing:

Persona

Provide 3 pieces of constructive feedback that could help the app to be better suited to the scenario it was designed for

  1. Number of employees at different companies throughout the years. If I were a video game developer, I would be curious who is growing the fastest (that will probably have to be some other dataset).

  2. It would be interesting to see all categories mapped out to see who has the highest volume of sales in general over time.

Provide 3 pieces of constructive feedback that could help the app to be better suited to the user(persona) it was designed for

  1. I think if I were Gordon, I would be curious how sales are changing by the platform over time. That could be another filter.

  2. On Kaggle I could see that the dataset contains specific games, so it would be interesting which ones were the most popular ones. It helps to identify the most innovative/interesting studios at the time.

Frontend / layout

Is the text (plot labels / titles / subtitles) easy to read?

Are the plots selected appropiated for the data? Can you think of other alternatives or improvements for the plots regarding interactivity/reactivity or plot selection?

Was the dashboard organized in a way that was easy to read (columns / rows) or you would suggest a change in this sense?

Would you prefer including tabs / navbars to improve the navigation or you think it is better to visualize everything in one screen by the nature of the content?

Are the plots or other images described properly for the persona described?

Backend

Are the options that you can select in the widgets working fine or have you found some cases where it is not working?

Documentation

Was the documentation easy to understand from the README.md how to use the app? How could the documentation be improved?

Was the app intuitive to use without reading the documentation? What information could be good to include?

Indicate something you would like to include in your own app after reviewing this one

👍🎉

Overall, nice and simple. I understood right away how to use it and didn't have to do any double takes. Also, the gradient is a lovely touch!