UBC-MDS / DSCI532-peer-review

0 stars 5 forks source link

world-energy-visualization-r - Group 7 #5

Open miyer26 opened 2 years ago

miyer26 commented 2 years ago

DSCI532-peer-review

  1. Open an issue with the name of your group and app Use this template:

To complete by the group


  1. Review the group that is one number ahead of your group's number. For example, if you are group 5, review group 6. If you are group 30, review group 1. Paste your answers in the issue of the group assigned.

To complete by the group reviewing:

Persona

Frontend / layout

Backend

Documentation

Indicate something you would like to include in your own app after reviewing this one


nd265 commented 2 years ago

DSCI532-peer-review

General comments: Great work team, I really liked the problem statement that you are trying to solve using this dashboard. Climate change is serious and it is important to learn if and how the world is shifting to other forms of energy to mitigate adverse effects of climate change. And the dashboard looks really good overall. Neat and tidy, with great use of bootstrap to style elements!

Persona

  1. The navigation bar in the Trends tab does not provide space to load other regions as a dropdown which, can be seen in the pic below. It would be better if the design of the nav bar can be tweaked a bit to accomodate space for the dropdown's options image
  2. When I try to visualize the bottom ranked countries, it displays an empty plot. I think this issue might have to do something with the data coming from the backend. I have attached snippet for your reference here image
  3. It would be better if the year slider is at the top of the world map(like it is on the top in the Trends tab), that way a user won't have to scroll down and then look at the map above, which makes it more intuitive and user friendly.

Frontend / layout

Backend

Documentation

Indicate something you would like to include in your own app after reviewing this