marvinmin
commented
4 years ago Thank you very much for your comments, Hossameldin.
- We will try to add a description of our app at the beginning. If there is no time, we will add that to our R app.
- For your comment on adding a slider to control year for the unemployment by year tab, we think it is unnecessary because the purpose of this tab is to show the change across the years as you can see that the x-axis of the chart is the year.
- It is very good advice to add select all in the dropdown menu and we will try to add that feature for our R app.
- In the seasonal unemployment tab, the slider is to choose one year to show the seasonal change in that year. And we made it clear that it is the year you are choosing, not the year range. But your confusion reminds us we may need to change the slider to something else like radio buttons. We plan to change that for our R app.
- Thank you for reminding us about the data source. We'll add the data source.
Hello,
Thank you for your submission of milestone 2. I am sure that you put a lot of effort into producing the app and its documentation. I see that you are always commiting and using pull requests, but try to add an extended description of the commits that you find a little vague. You also use issues for communication and task assignment, but I see that team members tend not to comment on issues.
Regarding the app, I like how you use a mix of bar, and line plots for visualizations. I also liked the interactive features that you added. I have some suggestions for the app that I will be listing below.