UBC-MDS / DSCI_522_G410

Group repo for DSCI522 (group 410)
MIT License
0 stars 4 forks source link

Path in your usage should not be a local path.. #51

Closed firasm closed 4 years ago

firasm commented 4 years ago

I was trying to reproduce some of your analysis to help troubleshoot and noticed this:

# 1. Downloads, saves, and splits FIFA data: note absolute paths should be replaced with user-specific path
RScript .\src\save_download.R --'/Users/huayuelu/Desktop/DSCI_522_G410/data/fifa_data_train.csv' --'/Users/huayuelu/Desktop/DSCI_522_G410/data/fifa_data_test.csv'  --https://raw.githubusercontent.com/mglu123/live_dash_demo/master/data-2.csv

You should not run these scripts with files referenced outside of the repo

hwilliams10 commented 4 years ago

Got it. That was the first thing we fixed this week. It does work with relative paths now, and it has been updated in our makefile accordingly.