search

UBC-MDS / DSCI_522_GROUP_312

MIT License
0 stars 2 forks source link

Milestone 3: Code Quality #59

Closed ksedivyhaley closed 4 years ago

ksedivyhaley commented 4 years ago
slbsolomon commented 4 years ago

Hi Kate, I thought we had agreed in the previous feedback that the example URLs weren't necessary for this particular project. I realize that we took the information out of the README, but looking at Tiffany's example, she neither has this in the README or in her documentation. Here was her milestone 3 commit: https://github.com/ttimbers/breast_cancer_predictor/tree/58eb063f8d43af9bfcfc5a1ba5ff96826670775f

slbsolomon commented 4 years ago

@EitharAlfatih may you please update the Makefile

ksedivyhaley commented 4 years ago

Hi Kate, I thought we had agreed in the previous feedback that the example URLs weren't necessary for this particular project. I realize that we took the information out of the README, but looking at Tiffany's example, she neither has this in the README or in her documentation. Here was her milestone 3 commit: https://github.com/ttimbers/breast_cancer_predictor/tree/58eb063f8d43af9bfcfc5a1ba5ff96826670775f

Thanks for reminding me of our previous discussion - I see that now in issue #42 (note: good practice to link to related issues though unfortunately I haven't been able to do that consistently in feedback).

Given this discussion, I will not mark off for this for Milestone 3. I will consider whether this is something you should include for Milestone 4, and get back to you in lab. I note that Tiffany's example did not include such documentation, but it's still something I'd consider best practice.

slbsolomon commented 4 years ago

Hi Kate,

As we discussed yesterday, we confirmed that the majority of our comments were pushed before the released was created. The final comments at the top of the make file were added in #70.

ksedivyhaley commented 4 years ago

Thanks for the reminder, I've made a note!

On Fri, Feb 7, 2020 at 1:18 PM slbsolomon notifications@github.com wrote:

Closed #59 https://github.com/UBC-MDS/DSCI_522_GROUP_312/issues/59.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/UBC-MDS/DSCI_522_GROUP_312/issues/59?email_source=notifications&email_token=AEYDXYYSJGCZ7LUYOTAEXDLRBXF3PA5CNFSM4KQQ42M2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWP2FQVA#event-3019135060, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYDXYYRFX3LDQUUJOY5623RBXF3PANCNFSM4KQQ42MQ .