UBC-MDS / DSCI_522_Group-11_Save-The-Earth

MIT License
0 stars 0 forks source link

Created Changelog and updated docstring for evaluate script #64

Closed Aishwarya120111 closed 11 months ago

Aishwarya120111 commented 11 months ago

I have created the changelog and updated docstring for evaluate script. Kindly review the changes and let me know your feedback.

Jing-19 commented 11 months ago

I think it might be more helpful to add a few sentences about the improvements that we have made.

For the EDA part please add: "We added a descriptive plot title to both EDA distribution plots to make it easier for the audiences to understand. To further improve the readability, we removed the 'year' subplot to make the message more clear that we have a skewed distribution for all the energy consumption features."

Jing-19 commented 11 months ago

@WeilinHan8 Please add a sentence or two description of changes you made on the report about data for the changelog! Thanks.

WeilinHan8 commented 11 months ago

@Aishwarya120111 could you please update changelog by adding following content in updating ipynb part: Adding raw data description to provide details of CO2 emission, energy consumption and energy generation datasets. Updating data wrangling rationale and showing the final processed dataset that used for modeling.

Aishwarya120111 commented 11 months ago

I have made the requested changes...Kindly verify it