search

UBC-MDS / DSCI_522_Group-308_Used-Cars

This project attempts to build a regression model to predict price of used cars based on numerous features of the car
MIT License
2 stars 6 forks source link

Missing documentation - how to run in docker #74

Closed firasm closed 4 years ago

firasm commented 4 years ago

Hey @pokrovskyy @bradentam and @AndresPitta,

I'm not sure what's going on but your repo is missing some crucial documentation - how to run your analysis using a docker container.

See image below from milestone 4.

Could you please add the two lines of code required to run your analysis to this repo?

Screen Shot 2020-02-11 at 7 34 15 PM

AndresPitta commented 4 years ago

Hi Firas,

We wrote this commands on the makefile so that the user only has to type make run_quick_from_docker and it does the trick.

firasm commented 4 years ago

Ah - interesting! Indeed that does work.

Very nice!

let me think about whether this is a good idea or bad...

AndresPitta commented 4 years ago

Correction

The command is quick_docker

4659673B-3913-4CFC-9221-3D69209DAE12 D28C397C-CC0C-4E78-B7B5-112F02C78CD7

AndresPitta commented 4 years ago

Thanks @firasm,

Our reasoning behind it was making a cleaner version for the user (instead of having the user replace the path a probably making mistakes during that process).

firasm commented 4 years ago

Yep - I can see the advantages of this. I'm convinced!

Well done - spark mark!