Final Feedback (milestone 4) - Githubissues

UBC-MDS / DSCI_522_Group-308_Used-Cars

This project attempts to build a regression model to predict price of used cars based on numerous features of the car

MIT License

2 stars 6 forks source link

Final Feedback (milestone 4) #75

Open ksedivyhaley opened 4 years ago

ksedivyhaley commented 4 years ago

Mechanics ++

Usage instructions are fantastic - super convenient.
Both Makefile images look good

Quality - nice!

Dockerfile is well documented
Makefile documentation is now excellent
Wrangling corrected as requested

Viz

Tables look excellent!
Still some figure formatting feedback that could be addressed - text size on first figure, captions for figures/tables, and side-by-side layout for Figure 1: see #52
Why did you remove Figure 3 (the correlation plot)? It was a good figure.

Report

Minor typos (eg, "on a gradually increasing subsets", "luxery")
Would like to see you decide which of your peer feedback you would address if you ever come back to this project (#40, #41, and #43) and re-open those issues or create a new issue.
Overall, this is really well done. I like your end goal of developing an interactive tool that can take car data and output price!

pokrovskyy commented 4 years ago

Thanks for your feedback, Kate! I created an issue with future considerations for the project #76. I'd love to make another round of updates to wrap it up / cleanup / improve for it to be well representative of our experience (to be able to be showcased)