UBC-MDS / DSCI_522_Group_18

Group project repo for DSCI 522
MIT License
0 stars 5 forks source link

MIlestone 2 General Feedback #35

Open ahofmann4 opened 3 years ago

ahofmann4 commented 3 years ago

Hello Group 18!

Well done with your project! The Jane Austen quote was a nice touch :) Your code ran smoothly, and I can see that you used github issues and commit titles effectively. It might be good as part of the process to open a few more issues to track the overall progress of the team.

Report suggestions: 1) Table of contents missing 2) what does wrt in figure legends mean? 3) having the 0/1 labeled on the x-axis as <50k and >50K would make it easier to understand, and not have to keep double checking which is which 4) Figure 1 is listed for both box-plots, change second one to Figure 2 5) why is the summary at the beginning of the report did you report overall accuracy of 1. Where does this come from? and how is this possible with 1806 incorrectly predicted examples? Final conclusion is not as optimistic in its claims as the summary. Align the summary with the conclusions and discussion. 6) unclear from the report if you kept the features of the dataset in the model or only the ones you showed inthe box-plots? 7) it would also be nice if you just mentioned that the features are not correlated, tbh I think the correlation plot is more useful to look at than the box-plots because it is not clear to me why the box-plots are being shown. I understand that maybe these are the features you think might best help predict income levels, but this is not clear, nor is it addressed at the end whether these features were most useful in the models for predicting or not.

AishwaryaGopal12 commented 3 years ago

Added table of contents. Changed the summary to report accurate results Explained the selection of features by adding box plots for all numeric variables and also the correlation heat map