UBC-MDS / DSCI_522_Group_18

Group project repo for DSCI 522
MIT License
0 stars 5 forks source link

Peer Review - Jayme Gordon #47

Closed jaymegordo closed 3 years ago

jaymegordo commented 3 years ago

Hi, Group 18!

I apologize this is probably too late to be useful, but I'll let you know my thoughts after reviewing your project anyways.

Documentation

Very clear and easy to follow, well done!

Code

Overall very clean and well written. Only small thing I noticed is that you have multiple tab indentation sizes, everything from 2 to 8-spaced tabs. I'd suggest just making sure everyone has their editors set to the same tab-size setting, or even just use a code formatter like black. Code itself is great though!

Analysis and Reasoning

I recognize the data set! All your analysis, choices of metrics, and conclusions seem apropriate.

Communication

The report is very well laid out, with appropriate paragraph sizing, and very clear figures and tables. Very enjoyable to read. Only tiny thing I would suggest is to fomat large integer numbers with commas eg 50,000 instead of 50000. That may just be a personal preference but I find it much easier to read.

Suggestions

I included a couple small things in the categories above.