search

UBC-MDS / DSCI_522_Salary-vs-College

DSCI_552 milestone project
0 stars 3 forks source link

missing dependencies for this rule #46

Closed ttimbers closed 5 years ago

ttimbers commented 5 years ago

https://github.com/UBC-MDS/DSCI_522_Salary-vs-College/blob/e835d7666c853c8e8aaa780863d4719f41f1677c/Makefile#L42

This rule (which builds the report as the target) depends on ALOT of files that are not listed here (i.e., all the images and csvs that you load in your report). These should all be listed as the dependencies (after doc/Final_Report : doc/college_salary_report.Rmd) in this rule.

ttimbers commented 5 years ago

A related comment is that your all dependency should really be doc/college_salary_report.md.

ttimbers commented 5 years ago

And actually, the target currently called doc/Final_Report should be instead called doc/college_salary_report.md.

shusterc commented 5 years ago

I add all the dependencies to this rule and all dependency was changed to include only .md file