Milestone 3: Viz feedback

UBC-MDS / DSCI_522_group-314

Prediction of Customer Default

MIT License

0 stars 3 forks source link

Milestone 3: Viz feedback #54

Open ksedivyhaley opened 4 years ago

ksedivyhaley commented 4 years ago

Improvements to figures make a big difference! A few improvements remain.

Table 1 should still display fewer significant figures, and use nicer column labels
Fig 1 could still be improved by setting the diagonal values to be a colour other than the highest value (eg 0 or NAN).
Fig 2 is improved as a violin plot, though pay_amts are still hard to visualize because of the skew - could you separate these features and plot them on log scale?
Figs 1 and 2 could use more reader-friendly labels
Fig 3 does look better as a side-by-side, and the axis labels are much better!
Table 2 should display fewer significant figures, but otherwise looks good!

firasm commented 4 years ago

Hey folks, sorry I wasn't able to give you feedback on your visualizations before lab today (I ran out of time), can you please flag me down today in the queue (just add your group number so I can get to you earlier) and I can give you some feedback in person? Sorry!

zoepan00 commented 4 years ago

will show less significant figures for tables. Will try log scale on voilin plot.
I'm not sure why we need to amend diagonal values color or change to NAN, because it is 1 for the variable itself. And the industry knows that and implement as is too.

firasm commented 4 years ago

Hi @zoepan00 - it's a good question why I asked you to set the diagonals to Nan or change the colour. Here are the reasons:

The diagonals actually have no meaning (correlating with itself) and appear as an artefact of the data frames as constructed
This is different from the y=x line drawn on ROC plots because that guides the user to how much better/worse you are from the y=x line
If the correlation matrix is coloured, it distracts from other relationships in your plot and adds a level of cognitive load that is not necessary.
If you want to keep the diagonal numbers in, you may, but set them to a different colour

zoepan00 commented 4 years ago

Got it Thank you for your explanation Firas. Not sure if that's a common practice. I did a little search online, looks like both are used. But I'll do that

firasm commented 4 years ago

Thanks - probably not common practice but it should be. I'll write a blog post on it one day