UBC-MDS / DSCI_522_group09_Wine_Quality_Predictor

A machine learning pipeline for classification and prediction of wine quality based on relevant features
https://ubc-mds.github.io/DSCI_522_group09_Wine_Quality_Predictor/index.html
MIT License
4 stars 6 forks source link

Test Reproduceability #135

Closed gfairbro closed 2 years ago

gfairbro commented 2 years ago

Each team member will attempt to run the entire pipeline

gfairbro commented 2 years ago

I was able to run this completely in 5 minutes, including download of container

GloriaWYY commented 2 years ago

I was able to run this, docker build takes around 5 minutes, and docker run takes another 7 minutes.

gfairbro commented 2 years ago

@GloriaWYY did you just run it like this? docker run --rm -it -v :/home/jovyan/ gfairbro/wine_quality_predictor make all Shouldnt have been more than one step.

GloriaWYY commented 2 years ago

@gfairbro I did $ docker build --tag wine_quality_predictor ., and then $ docker run --rm -it -v /$(pwd):/home/jovyan/ wine_quality_predictor make all

So the docker build command is not needed actually?

gfairbro commented 2 years ago

Not needed. what the run command with gfairbro/wine_quality_predictor will do is download the container image (if it is not already present on your computer) from my repo and run it.

GloriaWYY commented 2 years ago

@gfairbro Oh, yeah, that's because you already published the image on your DockHub? So we don't need to build it from the Dockerfile

gfairbro commented 2 years ago

Yep you got it!

gfairbro commented 2 years ago

Reproduceable except docker issues with M1.