TA comments

[slumnitz]

Hello everyone,

here are a couple important notes for you in order to not loose marks:

• Ensure everyone is getting a chance to code, commit and submit pull requests, and that work is being distributed equally.
• Some commit messages are not informative enough, for example “updates”.
• Moving forward, remember to communicate with your team by creating new Issues.

[slumnitz]

Hello team,

here are another couple suggestions and minor comments to look out for:

• You coud add more detailed annotations and text passages in the sketch, to show what can be used how.
• Team work contract could be more specific: What are tasks? Who takes which jobs? When are they due?

[slumnitz]

@vanandsh @sirine-chahma @braydentang1

[braydentang1]

• [X] Teamwork contract update to be more detailed.

• [X] Sketch needs to be more detailed.

[slumnitz]

Hello all, first of all, great work! You implemented previous comments well, your commit messages read nice and meaningful and you all worked well in a team!

Here is a little bonus how you could further improve your commits if you chose though:

• note that you could add more information in your commit on a third, or fourth line, you would usually add a blank line after the short commit message and could explain a bit more in detail what changed.
• in very big projects it is common to use tag words at the beginning of your commit to indicate which part of the code was chaged, e.g. [DOC] for documentation, [BUG] for fixed bug or [ENH] for adding code or functionality. You could leverage this instead which would shorten your commit messages. I.e. '[ENH] Add year_filter(year = None)`
• generally it is best to commit frequently, i.e. while you are developing an new function and make a PR when the function is finished, with all the commits used to develop this new function