search

UBC-MDS / DSCI_532_group_205

Movies Dashboard (Python)
MIT License
1 stars 4 forks source link

upper figure addition to the app #16

Closed fkhan72 closed 4 years ago

fkhan72 commented 4 years ago

I have added all the required files and the app seems to be working well. While I was playing with the app, I found some differences in the upper and lower figures. Screenshot from 2019-11-29 18-54-27 In this figure, there are fewer ratings than the movies and the reason is bc some movies have nan reviews and those movies dont show up on the chart. If we remove the labels then it can cause some confusion to the user. It also messes up the movie colors between the two plots.

A way out to this is to make the lower figures variables for both charts nominal rather than quantitative and then you get Screenshot from 2019-11-29 18-58-19

The axis are all mixed up here. But, that can be fixed I guess. Either we fix this or include the legends in the lower fig and use different color scheme and mention in the app that only the movies having the reviews show up. I let you guys decide on that. I am good either way.

techrah commented 4 years ago

Great work solving the issue with the NaN ratings. This only becomes an issue if it's one of the top movies. Otherwise, they just "fade" into the background anyway. Let's leave like this for now.

As for the lower legend, I believe @sreejithmunthikodu will remove it completely as it's now redundant.