search

UBC-MDS / DSCI_532_group_205

Movies Dashboard (Python)
MIT License
1 stars 4 forks source link

Remove legend all-together #20

Closed techrah closed 4 years ago

techrah commented 4 years ago

I've gotten the interaction to work between the two charts. However, the top chart is heavy with text on both sides. I wish I could move the legend to the lower chart but I'm not sure that's possible.

The chart looks like this when a single movie is selected.

image

I'm thinking of just removing the legend all-together because the information is already on the left side of the upper chart with all the same colour encodings. Do you agree that we can remove it without affecting the information available?

sreejithmunthikodu commented 4 years ago

Great work Ryan. I totally agree we should remove legend from both the plots. It is redundant.

sreejithmunthikodu commented 4 years ago

For handling NaN in the ratings, we have two other options compared to the current version.

  1. drop nas from top chart as well for non-rated movies
  2. fill na in the rating with the mean across all movies

what is more appropriate?

techrah commented 4 years ago

Ok, I'll work on removing the legends and adjusting the UI.

sreejithmunthikodu commented 4 years ago

legends removed, nans dropped