UBC-MDS / DSCI_532_group_205

Movies Dashboard (Python)
MIT License
1 stars 4 forks source link

Fixes to Date Range selection #33

Open techrah opened 4 years ago

techrah commented 4 years ago

Based on peer feedback:

techrah commented 4 years ago

UPDATE: More details on the issue.

The reason that validation in the dropdown control was not implemented in the first place was because Dash callbacks cannot handle inputs and outputs being the same control.

https://community.plot.ly/t/same-input-and-output-in-a-callback/20002

This means that if I change the start year which calls some callback function... and it happens that the year is larger than the end year, that function cannot update the control that called it and reset the year back to a sane value.

sreejithmunthikodu commented 4 years ago

Thanks Ryan for the info. I implemented the alternate solution in #36

techrah commented 4 years ago

Reopening this issue. This does not seem to be working on the deployed app.