search

UBC-MDS / Giant_Pumpkins_Weight_Prediction

Other
1 stars 9 forks source link

Suggestion for Improvement and M3 #38

Open imtvwy opened 2 years ago

imtvwy commented 2 years ago
  1. Pass results using file instead of passing parameters (Vanessa)
  2. Makefile (Mahsa)
  3. Address peer's comment (selected or just giving feedback in Issue) (Shiva)
  4. Use modular functions in scripts (Shiva, if time permits)
  5. Add Future Improvement section (look for more features e.g. seed/genetic data; try other regressor, RandomForestRegressor) (Rowan)
mahsasarafrazi commented 2 years ago

folks, as I talked with other students, it seems we should reply to milestone feedbacks. I think the TA feedbacks are more related to classification and not regression, so it is better to address him so that we do not lose the mark for the next milestones. we can each reply or we can select one of us answer to the feedback. which do you think is better?

shivajena commented 2 years ago

I have elaborated our discussed views on TA feedback. Yes Mahsa, they are more classification related rather than regression, and hence, I have indicated them. Some of the observations were pertaining to peer feedbacks are being worked upon and will create a PR soon on it with details of works done.

shivajena commented 2 years ago

I have reverted to TA feedbacks as discussed and also responded to two of the four peer reviews which were received earlier this week. Accordingly, I have made the following changes with respect to the feedbacks received and as per the team discussions: