Milestone 2 Feedback

[ogarland]

Congratulations on finishing milestone 2! Below is the grading scheme for this deliverable.

Mechanics: 2/4 o The links are missing in the canvas submission. -2 mechanics

Developing your Shiny App: mechanics: 10/15, quality: 5/5, viz: 10/15, accuracy: 7/7 o There is not one branch by each team member. -5 mechanics o The elements of the app aren't organized effectively. -5 viz

• I would consider reorganizing the layout of features in the app. When testing it out, I didn’t find it to be super intuitive and it took a few minutes for me to understand what was being plotted. Specifically, because the buttons to plot are placed on the left column (before the food entry) it made me think there would be another to add the food entries after. I see now that it will update once I input a food and click them, but this order is not standard in UIs
• Use consistent labeling/naming of the plot buttons, one should not be a question and the other not.
• There is an overlap between the plots and labels (ex “Weights” and the macronutrient plot)
• I couldn’t see my own manual input for the weight of foods because the input box isn’t sized appropriately.
• Review spelling, ex. “Macroutrient Totals”
• Minor comment, but consider giving the user the option for either the slider or manual input (maybe a drop-down) and then just let one appear and have 1 plot button.
• “About”, “Data” and “Download” pages are blank
• I like your “Statistics” page with food rankings I think that’s a creative and useful feature!

Reflection: reasoning: 6/6

README: reasoning: 6/6

Grade 46/58. Great job! Please let me know if you have any questions or would like to discuss any of these points further.

[samson-bakos]

Hi @ogarland Olivia, thanks for your feedback. A few concerns:

• For branches, we did have branches (multiple per person), but before submission we cleaned up the repo by deleting unused branches. You can see evidence of our branch usage here: https://github.com/UBC-MDS/MacroView/commits/main (multiple merge statements, 1 per branch. All commits are on these branches). Or I think @austin-shih can restore them since he did the cleanup
• Regarding links, it wasn't clear that anything was needed besides the link to repo as it was at submission:

"Once you have finished the work for this milestone you must create a release on GitHub.com before the submission deadline"

"We will grade all files in the repo at the state they were in when you created the release"

This implies nothing is needed here except the release; repo link wasn't requested.

• I'm not sure if any of the specific -5 for viz was due to this, but for the "About", "Data", "Download" pages, we explained in our reflection those are deliberately blank for development as part of improving/ finalizing our app in M4, with those headers just being placeholders for now in the M2 version. We didn't think it would be a problem since M2 was not intended to be a production deployment ready version, and they would be completed in M4. We wouldn't have added them if we knew it would be an issue, we were just setting up for future work.

[ogarland]

Hi @samson-bakos, for your first 2 points, I will consult with Florencia about this and get back to you by the end of the day on Wednesday.

For the blank pages, that's fine that they are blank, and good that you addressed it in your reflection, it was just a minor point I wanted to add as a "to do" in the feedback. The grade will remain the same based on the other points noted.

[ogarland]

Hi @samson-bakos, I have awarded points back for the link submission. As for the branches, this was a requirement set in the rubric so if you would like to request a regrade on that point please reach out to Florencia on slack, you can include me in a group chat if you would like.

You should see your mark updated on canvas. If you don't see it within the next day please let me know.