search

UBC-MDS / Mental-Health-in-Tech-Dashboard

The Mental Health in Tech Dashboard visualizes a dataset consisting of survey questions and responses about various aspects of the mental health of tech workers.
https://mentalhealth-in-tech.herokuapp.com/
MIT License
4 stars 3 forks source link

Confirming PR Process #16

Closed d-sel closed 3 years ago

d-sel commented 3 years ago

Hi @chiragrank @mikelynch416 @fatse , I would like to clarify process for approving PRs. We only need one person to approve even though all three are requested to review - is that correct?

Thanks, Selma

chiragrank commented 3 years ago

Yes, you are right. I think we discussed that a minimum of one approval would be required. So it can be merged right away if the approver feels confident of the changes. If the approver feels more consensus would be better for that pull request, it can wait for other approvals. Having the requirement of one approval would help us to speed up things and not making a hard rule can help us get more opinion whenever possible. Would be helpful to get inputs from others as well on this.

d-sel commented 3 years ago

Finished discussion in meeting 21/01/21.