search

UBC-MDS / PyDataPeek

MIT License
1 stars 1 forks source link

Feedback of Milestone 3 #50

Open Doooooris opened 4 years ago

Doooooris commented 4 years ago

PYTHON

  1. pip install python package failed. Try 'pip install -i https://test.pypi.org/simple/ pydatapeek'. Looking in indexes: https://test.pypi.org/simple/ ERROR: Could not find a version that satisfies the requirement pydatapeek (from versions: none) ERROR: No matching distribution found for pydatapeek.
  2. The unit test did not pass. Try 'poetry install; poetry run pytest tests'. 5 error shows up. Seems like all of them are regarding 'chromedriver';
  3. 'pdp.missing_data_overview('example.csv')' is incorrect, the example file is under usage folder. Change it to 'pdp.missing_data_overview('usage/example.csv')'.

R

  1. 'use vignette package-wide documentation in R, as well as the pkgdown R package to set up a website for your package'. I didn't find the link to vignette in README. No r document available. Message me if you guys have the vignette ready, and forgot to put the link in readme.