search

UBC-MDS / PyDataPeek

MIT License
1 stars 1 forks source link

Missing data overview #53

Closed alistair-clark closed 4 years ago

alistair-clark commented 4 years ago

This PR contains fixes for 3 pieces of feedback from Elliot and Aman:

  1. Aman's feedback that an empty string isn't represented as missing. I updated the docstring to clarify that only NaN values would be caught.
  2. Elliot's feedback that the heatmap documentation was unclear. I updated the docstring to explain the output.
  3. Elliot's feedback that the heatmap axis labels were too small. I updated the function to increase the label size.
codecov[bot] commented 4 years ago

Codecov Report

Merging #53 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          10       10           
  Lines         316      317    +1     
=======================================
+ Hits          310      311    +1     
  Misses          6        6
Flag Coverage Δ
#unittests 98.10% <100.00%> (+<0.01%) :arrow_up:
Impacted Files Coverage Δ
PyDataPeek/PyDataPeek.py 88.57% <ø> (ø)
PyDataPeek/__init__.py 100.00% <100.00%> (ø)
PyDataPeek/missing_data_overview.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d4687d...5a09721. Read the comment docs.