search

UBC-MDS / RaincouverPrediction

Group 9 shared repository for 522
https://ubc-mds.github.io/RaincouverPrediction/
Other
0 stars 3 forks source link

Milestone 4: Update README #91

Open dorisyycai opened 11 months ago

dorisyycai commented 11 months ago

feedback: I was able to enter the docker container and reproduce the results from the JL terminal. Great work! Instructions are easy to follow. Tests, scripts and jupyter book are working. Do we also need to have instructions to reproduce the analysis in the virtual environment? Perhaps something to consider adding.

README.md - Add more references in README.md

Reproducibility: Was unable to open Jupyter book locally following the instructions on README.md.

dorisyycai commented 11 months ago

We may need to add packages in environment.yml as we added more packages to dockerfile and ran report in container.

dorisyycai commented 11 months ago

Checked with Tiffany, we can only focus on reproducing our report in dockerfile container and make sure dockerfile working properly. Hence, we decided to move the environment.yml to archive folder to avoid confusion.

dorisyycai commented 11 months ago

For reference, we confirmed that we have put all references needed in README.