search

UBC-MDS / Wine_Quality_Predictor

MIT License
1 stars 6 forks source link

Update scripts and yml file #60

Closed rissangs closed 3 years ago

rissangs commented 3 years ago

  1. fit_wine_quality_predict_model.py (@BruhatM )

    • move main function up
      • add plotting
      • add save_plots function

  2. wine_ead.py (@wang-rui )

    • move main function up
    • add code in save_plots function to check output dir exists or not.

  3. reports.rmd (@athy9193)

    • change path for table1 and figure2 (haven't change any description of table and figure)

  4. wine_env.yml

    • add catboost

This PR refers to issue #40 , #41 , #43 and #47

athy9193 commented 3 years ago

Regarding the report.md, I changing the links is sufficient, I will take care of the rest. No worries. Based on the assessment, we should have no conflict.

rissangs commented 3 years ago

@athy9193

I have updated what you have mentioned.