search

UBC-MDS / airline-customer-satisfaction-predictor

MIT License
1 stars 0 forks source link

Good job! #4

Closed cs-uche closed 3 days ago

cs-uche commented 4 days ago 
          Good job!

The only thing is that: Method -> Model section at the top of the document does not match the model training we do. We should fix it.

Also, please refer to my issue and provide feedback about the suggestions.

Originally posted by @HrayrMuradyan in https://github.com/UBC-MDS/airline-customer-satisfaction-predictor/issues/3#issuecomment-2492879862

cs-uche commented 4 days ago

Great Point, deciding on a model before completing feature exploration should be discouraged. Additionally since the KNN Classifier can be used for Classification tasks it was included in the section Comparison Models

cs-uche commented 4 days ago

It was however commented out because the models took too long to run on my system this might because our current features need some feature engineering to optimize them for that classifier or my local system is not optimized for such tasks.

cs-uche commented 4 days ago

Consider uncommenting and running it on your system before merging

AzinPiran commented 3 days ago

problem was fixed.