UBC-MDS / canadian_heritage_funding

Report
https://htmlpreview.github.io/?https://github.com/UBC-MDS/canadian_heritage_funding/blob/main/doc/canadian_heritage_funding_report.html
Other
1 stars 7 forks source link

Milestone 3 #84

Open andytai7 opened 2 years ago

andytai7 commented 2 years ago

Dear Group 14,

Great job on milestone 3. Here is some feedback.

GitHub actions workflow for continuous integration for the Python project: Mechanics

Comments Everyone should contribute equally to all aspects of the project (e.g., code, writing, project management). Some students ( Aldojasb gutermanyair) are not commit the same as the others.

Python package documentation: Reasoning

Comments The Makefile must be well documented. This means comments throughout, readable code and a brief summary at the top of each file that answers who wrote it, when it was written and what it does.

Specific expectations for this milestone: Mechanics

Comments Where are your references in the Readme and project RMD file?

Thank you and good luck on Milestone 4!