search

UBC-MDS / chocolate_rating

Other
0 stars 3 forks source link

Milestone 3 - Feedback #87

Closed danielramandi closed 1 year ago

danielramandi commented 1 year ago

Congratulations on finishing milestone 3! We can see you put a lot of work into this project, nice work! Below we list some specific feedback you can use to improve your project. We provide tick boxes for you to use in the future as you address these concerns to improve the final grade of your project. If anything is unclear, please feel free to ask questions in this issue thread.

Comment: You can only use the final report html for the ‘all’ section. Also, add a comment somewhere that the clean commands are written for which OS. -rf is not defined in windows I think. Overall, well done! Works like a charm!

robindhillon1 commented 1 year ago

Hi Daniel, I specifically went to Florencia's office hours and she confirmed everything was good. She said as long as everything works as intended (which it does like you said), we have nothing to worry about. There was no mention of simplifying or efficiency (although what we did was efficient, I believe). So although it's only 2 marks, I don't think it's justified to be honest.

markusnam commented 1 year ago

Hi Daniel, on top of Robin's reply, I would like to say that our work was based on the breast_cancer project that Florencia always tells us to refer to. Here is the Makefile from the breast_cancer project. https://github.com/ttimbers/breast_cancer_predictor/blob/master/Makefile I would say our format is similar to the official reference.