search

UBC-MDS / citytemp

Citytemp is a R shiny dashboard presents temperature and precipitation trends and ranking of US cities by states.
https://eyrexh.shinyapps.io/citytemp
MIT License
0 stars 3 forks source link

Milestone 2 Feedback #53

Open negsadr opened 1 year ago

negsadr commented 1 year ago

Congratulations on finishing milestone 1! We can see you put a lot of work into this project, nice work! Below we list some specific feedback you can use to improve your project.
We provide tick boxes for you to use in the future as you address these concerns to improve the final grade of your project. If anything is unclear, please feel free to ask questions in this issue thread.

1. Submission instructions

rubric={mechanics:4}

Well done!

2. Developing your Shiny App

rubric={mechanics:15, quality:5, viz:15, accuracy:7}

Comments: -Map is not reflecting any filter selections. -In the “City Ranking by temp/rain” tab is there a specific reason for your decision to double coding (colour and size) precipitation and temperature? You might consider merging two tabs into one dashboard, given the amount of information in each tab. -In the “City Ranking by temp/rain” tab, when there are few cities in a state the size of the bars is not proportionate to the labels:

Screen Shot 2023-03-12 at 5 36 23 AM

3. Reflection

rubric={reasoning:6}

Well done!

4.Improve the README

rubric={reasoning:6}

Well done!

renee-kwon commented 1 year ago

Hi @negsadr, thank you very much for your valued feedback. We have a few questions regarding the deductions for mechanics.

1. the app's reactivity and your comment "-It is not possible to remove a country after selecting it." Could you clarify what you mean by this? Our app shows data for single cities within a state and not countries. We did not implement the ability to remove a location as this was not in our plans.

2. Not one branch by team member. It is not possible to recognize the contribution of each team member. Our group successfully made use of individual branches for each task we took on. Please review our use of branches in our commit history.

Thank you, Group 3

renee-kwon commented 1 year ago

Hi @negsadr, we have a grade of 49/58 on canvas but there is only 6 point deductions on here. Could you clarify? Thank you, Group 3

negsadr commented 1 year ago

I'm sorry for the confusion. The feedback posted here was actually not yours!

Now you should be able to see the correct feedback. Please let me know if you have any questions.

renee-kwon commented 1 year ago

Hi @negsadr and @flor14,

Thank you again for your feedback. We hope to explain our reasoning and receive some clarifications on the deductions from our milestone 2 submission.

Users have the option to click on the map to change the summary statistics and line plot and display the ‘Elevation’ and ‘Distance to Coast’ information, but it was not our intention for this to be updated with the control panel.

Our function was true to the description in our readme:

Based on user’s selection, our app will present: A map showing the average temperature or precipitation levels based on the range chosen by the user. City points are coloured from low to high temperature or precipitation levels.

Our app’s reactivity is working as our group expected and intended.

There are two main reasons why the app is organized with two tabs. The first reason is they show two different intentions ; the first tab describes data of a selected CITY and the second tab shows an overview of a specific STATE. The second reason is that it can alleviate the cognitive burden on the user by presenting a limited number of plots on the screen at a time.

It was also not mentioned in the milestone 2 instruction that we need to put a specific amount of elements in a single tab. But still according to this rubric, both tabs of our app contain 2-3 plots. We also used layout functions throughout our code to organize our plots. Could we get clarification on this deduction?

The size of the labels in our bar charts is not proportionate to the size of the bars as in Negar’s feedback, it might not be aesthetically beautiful but we believe that the plots and fonts are still easy to read and legible as the rubric mentioned. Proportionate font size is an improvement we can consider for the future but it was not intended for our milestone 2 submission.

Here is our repo release from milestone 2. We hope you will consider re-grading our submission based on the points above.

Thank you, Group 3

negsadr commented 1 year ago

Congrats team on finishing your project and hope you enjoyed working on it while learning. Upon your request I have modified your grade as below:

You are right! Your app is working as intended, but my point is that it might not work as the user will probably expect which may lead to confusion. Anyways, I will add +2 points to your grade as it was an issue of design but not implementation.

The number of plots should be more than 2 for each tab, but not equal to two, so unfortunately I can't add any marks here.

I will add +1.5here as this does not happen all the time and only when there are a few cities in that state.