Milestone2 feedback

[Kate96]

Hi,

Very useful app!

Some suggestions for the future:

• You seemed to have removed the proposal from the milestone 2 release? I would recommend to keep all the milestones as separate files instead of putting them in README
• I would add a checkbox to select school size instead of having multiple tabs
• I liked how you added the description of school sizes!
• The plot with % of female students goes from 0-1 and not 0-100
• Currently if a state doesn't have schools of specific size (eg AK state doesn't have large schools), this level disappears from the plots. I would make sure it is still displayed, but it would just be shown as 0.
• You could also make the side panel move when you scroll down so you don't have an empty space on the left and are able to filter easily at the bottom of the page
• Please make your variable names in the code (app.R) more specific
• Please split your code into multiple lines where possible for better readability (eg tabPanel lines)
• Please add more comments to the code and make them more descriptive (but concise!)
• All your distribution plots are grouped by school size, you can make your code more efficient to not repeat this. Similarly, a part where you filter by ADM_Rate_P could also be made into a new function
• Please add more comments about connection to the previous milestone(s)
• I also liked your plots, they look very nice!

[sedv8808]

Hi Kate, thank you very much for your feedback.

• Created folder docs where all the milestones live.
• Added a picker input to select school size.
• Female students plot, corrected.
• Bug fixed.
• Comments added to the app.

Some of the edits have been made and some will be for our last milestone/wishlist, as we see fit.

Thank you so much for your aid!