search

UBC-MDS / datascience_eda

This package includes functions helping with common tasks during EDA stage of a data science project
MIT License
0 stars 2 forks source link

Created funtion definition for EDA of numeric columns #14

Closed rahulkuriyedath closed 3 years ago

rahulkuriyedath commented 3 years ago

I have added function documentation for the explore_numeric_columns() function. @lephanthuymai please review and merge the code if it looks fine.

lephanthuymai commented 3 years ago

Hi Rahul, The change looks good. I talked to Tiff the other day and she said we should always return some values, so we can't return None. Probably just return a list of plots?

Thanks.

rahulkuriyedath commented 3 years ago

Hi Rahul, The change looks good. I talked to Tiff the other day and she said we should always return some values, so we can't return None. Probably just return a list of plots?

Thanks.

I have made the change. Could you have a look and approve if it looks good?