UBC-MDS / datascience_eda

This package includes functions helping with common tasks during EDA stage of a data science project
MIT License
0 stars 2 forks source link

Implement + unit test explore_clustering #29

Closed lephanthuymai closed 3 years ago

lephanthuymai commented 3 years ago

Hi Aditya et. al, Please help to review my PR with changes below:

I have run all the tests locally, they all passed.

Notes:

Thanks.

lephanthuymai commented 3 years ago

Hi @adibns , After some discussions with Tiff, Peter (TA), and Varada, I have updated the unit tests for verifying plots. The tests passed and the EDA notebook renders fine. Sorry that it will take you some time to review my commits again. Thank you for your help. Best, Mai