Closed lephanthuymai closed 3 years ago
Hi @adibns , After some discussions with Tiff, Peter (TA), and Varada, I have updated the unit tests for verifying plots. The tests passed and the EDA notebook renders fine. Sorry that it will take you some time to review my commits again. Thank you for your help. Best, Mai
Hi Aditya et. al, Please help to review my PR with changes below:
I have run all the tests locally, they all passed.
Notes:
matplotlib.use("Agg")
to disable opening plot windows in the test file, it causes some texts not generated for the plot objects, hence I can only do some simple tests for these plots. There are some other ideas for testing this kind of plot: https://stackoverflow.com/questions/27948126/how-can-i-write-unit-tests-against-code-that-uses-matplotlib, which I find quite complex. If you have better ideas on how to test them, please let me know.Thanks.