explore_text_columns - Githubissues

UBC-MDS / datascience_eda

This package includes functions helping with common tasks during EDA stage of a data science project

MIT License

0 stars 2 forks source link

explore_text_columns #30

Closed charlessuresh closed 3 years ago

charlessuresh commented 3 years ago

Wrote test cases and coded iteratively
added exception handling

The functions explore_text_columns and test_explore_text_columns are a bit long. However, because of time limitations, I don't think I can break them up into smaller functions in time for Milestone 2. I will probably reserve that for Milestone 3

@rahulkuriyedath please review @lephanthuymai @adibns feel free to review as well

charlessuresh commented 3 years ago

Updates:

merged with main (after explore_clustering PR was merged with main) and resolved conflicts
tested explore_text_columns in jupyter lab eda_playground.ipynb
used verify_plot function to test plots to prevent violating DRY principle

charlessuresh commented 3 years ago

updates to code after review by @lephanthuymai:

added code statement: nltk.download('stopwords')
added docstring for printmd function
added jupyter dependency

lephanthuymai commented 3 years ago

Looks good, great work! Thanks, Charles!