UBC-MDS / doggodash

The app recommends top dog breeds and other interesting facts based on certain traits selected by user, who could be a potential dog buyer.
http://dsci532-2022-group18-py.herokuapp.com/
MIT License
1 stars 1 forks source link

Peer review draft #47

Closed gn385x closed 2 years ago

gn385x commented 2 years ago

Group: 19 Name of the app: Data Science Salaries Link to the repo in milestone2: https://github.com/UBC-MDS/datasci_salaries_py/releases/tag/v0.2.0 Link to the proposal.md file where it is the description of the persona and scenario: https://github.com/UBC-MDS/datasci_salaries_py/blob/main/doc/proposal.md

gn385x commented 2 years ago

Persona

  1. In the usage scenario, Heroku needs to know how remote Data Science jobs compare with in-person jobs. Thus, I would suggest adding a chart to illustrate how the remote nature of the job impacts the salary by using the RemoteWork variable.
  2. To answer the stated research question "Data Science professionals in which countries are paid the highest?", I think it would be helpful to add a ranking plot of countries sorted by the salary statistics (i.e. median) so that users can quickly see the top five countries that pay data scientists the highest. The current world map is helpful, but is not as efficient when comparing countries.
  3. According to the usage scenario, Heroku wants to compare salaries in quite a few ways: (1) by country: Canada vs. US, (2) by education level: PhD vs. master's level, and (3) by work location: remote vs. in-person. If Heroku is a typical user for whom the dashboard is designed to help, I would suggest adding some sort of functionality where users can do comparison easily.
  1. It is likely that the user would be most interested in the salary distribution based on his/her own age, gender, education level, and coding experience. Thus, I suggest adding the capability to filter out those characteristics simultaneously. For example, if the user is a woman, she may primarily be interested in woman's salary distribution; therefore, she may not need to see the boxplot by gender.
  2. Coding experience is a key factor affecting placement and salary of newly graduated data science students. Therefore, I appreciate how the dashboard highlights its roles by giving it a substantial portion of the dashboard. However, I do not find the current version of this section very intuitive and effective, so there is more room for improvement. For example, I am not clear about the filter question "Are you a Data Scientist?"; or the interactive plot for each country seems to be more detailed than needed.
  3. Another possible improvement could be to give the option of using the converted currency in USD or the original currency as in the original data set. A Chinese user, for instance, who is only interested in the labor market in China, may prefer not to do all the conversion between USD and CNY.
gn385x commented 2 years ago

Frontend / layout

gn385x commented 2 years ago

hi @shivajena , @squisty , @stevenleung2018 , above is my draft for the peer review of the two sections that I'm responsible for. please take a look when possible and feel free to give feedback/ comments before I officially add those comments to group19's issue. thanks!