search

UBC-MDS / ds-toolbox

https://toolbox-learn.mds.ubc.ca/
Other
3 stars 6 forks source link

Revise module 3 #75

Closed joelostblom closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for cheerful-chebakia-6a18e7 ready!

Name Link
Latest commit 2aca60944b415d776939fa94e9f595f2eb518e72
Latest deploy log https://app.netlify.com/sites/cheerful-chebakia-6a18e7/deploys/62f01590ce9d30000824d921
Deploy Preview https://deploy-preview-75--cheerful-chebakia-6a18e7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for ds-toolbox ready!

Name Link
Latest commit 2aca60944b415d776939fa94e9f595f2eb518e72
Latest deploy log https://app.netlify.com/sites/ds-toolbox/deploys/62f0159084989e00094608b1
Deploy Preview https://deploy-preview-75--ds-toolbox.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

joelostblom commented 2 years ago

@flor14 This is ready for review!

joelostblom commented 2 years ago

@flor14 Thanks for the review! I have marked all your comments that I have addressed as "resolved". There are a few that are not yet resolved and I have left those open so that they are easy to find in our conversation above. The one major thing is the use of :raised_hands: in headings, and I have left a detailed reply to your comment regarding that.

I suggest that either one of us squash and merge this PR as it is now, and that you can work on adding the small additional things before you make the recording. How does that sound to you?