search

UBC-MDS / ds-toolbox

https://toolbox-learn.mds.ubc.ca/
Other
3 stars 6 forks source link

Revise module 4 #76

Closed joelostblom closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for cheerful-chebakia-6a18e7 ready!

Name Link
Latest commit 4bdb86eaf8790906dfbb407044f9902a2aae81f6
Latest deploy log https://app.netlify.com/sites/cheerful-chebakia-6a18e7/deploys/62f01ca337d70400095e76b0
Deploy Preview https://deploy-preview-76--cheerful-chebakia-6a18e7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for ds-toolbox ready!

Name Link
Latest commit 4bdb86eaf8790906dfbb407044f9902a2aae81f6
Latest deploy log https://app.netlify.com/sites/ds-toolbox/deploys/62f01ca3d0a8750008a9963b
Deploy Preview https://deploy-preview-76--ds-toolbox.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

joelostblom commented 2 years ago

@flor14 Thanks for the review! I have marked all your comments that I have addressed as "resolved". There are a few that are not yet resolved and I have left those open so that they are easy to find in our conversation above. The two main things are the standardization of : and () in headings, and the use of special words like reset and revert in headings.

I left replies to your comments on those topics, and my overall suggestion is that either one of us can "squash and merge" this PR as it is now, and then you can work on adding those few additional things before you make the recording. How does that sound to you?