search

UBC-MDS / ds-toolbox

https://toolbox-learn.mds.ubc.ca/
Other
3 stars 6 forks source link

Add videos module 3, 4 and 5 #99

Closed flor14 closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for ds-toolbox ready!

Name Link
Latest commit 67d7dae6cb200a4d14444332d74fab78d18fcf3e
Latest deploy log https://app.netlify.com/sites/ds-toolbox/deploys/6341b485d5853100082e71b3
Deploy Preview https://deploy-preview-99--ds-toolbox.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for cheerful-chebakia-6a18e7 ready!

Name Link
Latest commit 67d7dae6cb200a4d14444332d74fab78d18fcf3e
Latest deploy log https://app.netlify.com/sites/cheerful-chebakia-6a18e7/deploys/6341b4855842f700081b0c3f
Deploy Preview https://deploy-preview-99--cheerful-chebakia-6a18e7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

flor14 commented 2 years ago

Yes, I know. That is why I didn't assign you as reviewer. I will do this tomorrow.

Thank you for your time and comments anyway 🙂

El vie., 7 de octubre de 2022 4:40 p. m., Joel Ostblom < @.***> escribió:

@.**** requested changes on this pull request.

@flor14 https://github.com/flor14 I went through module 3 and there seems to be several video not starting and stopping at the correct time. I made comments for these but I didn't go through the other two modules yet, could you double check that all three modules' videos start and stop at the correct point in the netflix preview and I poing me so I can review again?

In chapters/en/module3.md https://github.com/UBC-MDS/ds-toolbox/pull/99#discussion_r990549174:

@@ -134,7 +134,7 @@ When you are cloning a repository you are downloading a .git hidden

- + This video starts with you saying "Let's apply what we learned" from the following slide deck, maybe shift over 1-2 seconds? This video also stops in the middle of a sentence ------------------------------ In chapters/en/module3.md : > @@ -258,7 +258,7 @@ Have you include the README.md file in the staging area? - + This seems to not be the entire video ------------------------------ In chapters/en/module3.md : > @@ -88,7 +88,7 @@ When you clone a Git repository from GitHub you get the hidden `.git` directory - + This video stops before the "Lets apply what we learned" slide. ------------------------------ In chapters/en/module3.md : > @@ -258,7 +258,7 @@ Have you include the README.md file in the staging area?

I think you missed one above does not have the correct video added.

In chapters/en/module3.md https://github.com/UBC-MDS/ds-toolbox/pull/99#discussion_r990552052:

@@ -303,7 +303,7 @@ The HASH code it is automatically generated by Git each time you create a commit

- + This starts in the middle of a slide. — Reply to this email directly, view it on GitHub , or unsubscribe . You are receiving this because you were mentioned.Message ID: ***@***.***>
joelostblom commented 2 years ago

Whooops sorry about that, I didn't understand this was still a draft

flor14 commented 2 years ago

@joelostblom here is my research about the copyright of the images (#5). There is only one image that could be problematic, but let me know your thoughts.

These are the images I have checked for copyright. Remember that all of them are included in the videos.