search

UBC-MDS / dsci-522_group-28

This is the repository for DSCI 522 Group 28
MIT License
0 stars 6 forks source link

TA Feedback (milestone 2): Feature selection #44

Closed jbourak closed 3 years ago

jbourak commented 3 years ago

Were the features that you found to be "viable useful predictors" using figures 1 & 2 the features you selected for the model? By only reading the report it is unclear which features you used in your comparisons. I suggest being more explicit when analyzing each plot (we will use feature A, B, and C) or summarize somewhere which features you will use (or maybe both!)

JaredSplinter commented 3 years ago

Hi Jordan,

Thanks for the feedback, I believe it was mentioned which features were dropped but I made it more explicit as suggested and added detail to which features were dropped and the remaining were used. At the time of making this report, we had not learned feature selection. I wrote in an improvements section about how we can use feature selection to try and find an imrpovement.